Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support RN 0.75 #2218

Merged
merged 19 commits into from
Jul 31, 2024
Merged

feat: support RN 0.75 #2218

merged 19 commits into from
Jul 31, 2024

Conversation

WoLewicki
Copy link
Member

Description

PR adding support for RN 0.75 in the library

j-piasecki
j-piasecki reviewed Jun 27, 2024
View reviewed changes
FabricExample/android/app/build.gradle Outdated Show resolved Hide resolved
FabricExample/ios/_xcode.env Outdated Show resolved Hide resolved
FabricExample/package.json Outdated Show resolved Hide resolved
@raghav-reglobe
Copy link

Hi, when can we expect this to be merged.

@WoLewicki
Copy link
Member Author

WoLewicki commented Jul 10, 2024 •
edited
Loading

I'm not sure @raghav-reglobe. What is the reason why you need it?

@raghav-reglobe
Copy link

@WoLewicki, thanks for asking.

I have migrated to react-native new architecture, but struggling with memory consumption, and animation performance(react-native-reanimated), Tried many things to optimize it.

So I am hoping for performance boost with react@19 updates, which is available in RN75, but unable to compile it, because of the few removed deprecated methods are being used this lib.

@WoLewicki
Copy link
Member Author

OK I get it. I think the best way forward for now is to use patch-package to get the needed changes in your project.

@imWildCat
Copy link

Is there any plan to release the change of this PR as an rc/beta version for the community to test?

@WoLewicki
Copy link
Member Author

We should release rc version in about 2 weeks. For now I suggest you do the thing mentioned in the comment

kkafar
kkafar requested changes Jul 30, 2024
View reviewed changes
Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few remarks from looking at the code.
I'll test runtime in a bit

FabricExample/babel.config.js Show resolved Hide resolved
android/src/fabric/java/com/swmansion/rnscreens/FabricEnabledViewGroup.kt Outdated Show resolved Hide resolved
ios/RNSScreen.mm Outdated Show resolved Hide resolved
ios/RNSScreen.mm Outdated Show resolved Hide resolved
kkafar
kkafar approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builded Paper/Fabric + iOS/Android combinations, did some sanity checks, seems ok! Thanks a lot!

@kkafar kkafar merged commit 8b6905a into main Jul 31, 2024
8 checks passed
@kkafar kkafar deleted the @wolewicki/support-RN-75 branch July 31, 2024 09:02
@WesleyR10 WesleyR10 mentioned this pull request Aug 21, 2024
Open
@shonore shonore mentioned this pull request Aug 22, 2024
Open
@2lambda123 2lambda123 mentioned this pull request Aug 22, 2024
Merged
@Cabreira97 Cabreira97 mentioned this pull request Aug 23, 2024
Closed
This was referenced Aug 23, 2024
Open
Open
Open
Open
@2lambda123 2lambda123 mentioned this pull request Aug 26, 2024
Merged
This was referenced Aug 27, 2024
Open
Open
Open
Open
Open
Open
Open
@shonore shonore mentioned this pull request Sep 3, 2024
Open
@undrthegraveyard undrthegraveyard mentioned this pull request Sep 4, 2024
Closed
@asraful-cse asraful-cse mentioned this pull request Sep 6, 2024
Open
This was referenced Sep 22, 2024
Open
Open
This was referenced Sep 24, 2024
Open
Open
Open
Open
Open
Open
@Ayush-Bulbule Ayush-Bulbule mentioned this pull request Oct 2, 2024
Merged
@tobistudio tobistudio mentioned this pull request Oct 3, 2024
Open
ja1ns pushed a commit to WiseOwlTech/react-native-screens that referenced this pull request Oct 9, 2024
@WoLewicki @kkafar @ja1ns
feat: support RN 0.75 (software-mansion#2218)
7dfef7a 
## Description

<!--
Description and motivation for this PR.

Include Fixes #<number> if this is fixing some issue.

Fixes # .
-->

PR adding support for RN 0.75 in the library

---------

Co-authored-by: Kacper Kafara <kacperkafara@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-piasecki j-piasecki j-piasecki left review comments

@kkafar kkafar kkafar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WoLewicki @raghav-reglobe @imWildCat @j-piasecki @kkafar